Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc St-Jean wrote:
+inline static void
+mspeth_skb_headerinit(struct sk_buff *skb)
+{
+	/* these are essential before init */
+	dst_release(skb->dst);
+#ifdef CONFIG_XFRM
+	secpath_put(skb->sp);
+#endif
+#ifdef CONFIG_NETFILTER
+	nf_conntrack_put(skb->nfct);
+#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
+	nf_conntrack_put_reasm(skb->nfct_reasm);
+#endif
+#ifdef CONFIG_BRIDGE_NETFILTER
+	nf_bridge_put(skb->nf_bridge);
+#endif
+#endif /* CONFIG_NETFILTER */
+
+	/*
+	 * Now initialise the skb...
+	 * Clear the members till skb->truesize.
+	 */
+	memset(skb, 0, offsetof(struct sk_buff, truesize));
+}
+#endif /* CONFIG_MSPETH_SKB_RECYCLE */

Did you ever resend this driver addition, with the above unmaintainable skb init hacks removed?

	Jeff




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux