Re: [PATCH] MIPS: Run checksyscalls for N32 and O32 ABI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/14/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
On Mon, 14 May 2007 09:55:01 +0200, "Franck Bui-Huu" <vagabon.xyz@xxxxxxxxx> wrote:
> > Without that, fresh build will fail because missing-syscalls target
> > requires include/asm, etc.
>
> yes but from top makefile, we already have this depedency:
>
>         $ grep archprepare: Makefile
>         archprepare: prepare1 scripts_basic

Yes, and arch Makefile is included _before_ the line.  So "make" will
try to build arch-missing-syscalls before prepare1.


hmm okay. But this depedency is not really nice IMHO...

Something weird is that if you do this on top of your patch, it seems to work:

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 5aa0f41..04a57f9 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -713,7 +713,7 @@ ifdef CONFIG_MIPS32_O32
       $(Q)$(MAKE) $(build)=. missing-syscalls EXTRA_CFLAGS="-mabi=32"
endif

-archprepare: arch-missing-syscalls
+prepare0: arch-missing-syscalls

archclean:
       @$(MAKE) $(clean)=arch/mips/boot

It seems that we can't rely on the order of the execution of megerd
prerequisites...
--
              Franck


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux