Hello. Atsushi Nemoto wrote:
NETPOLL support for Sibyte MAC
Signed-off-by: Manish Lachwani <mlachwani@xxxxxxxxxx> Signed-off-by: Deepak Saxena <dsaxena@xxxxxxxxxx>
If you added NETPOLL support, do not forget to ensure hard_start_xmit routine callable from interrupt context (or irq disabled). See commit bce305f4fe779f29d99d414685243f5da0803254 for example.
You're absolutely right: this driver is very likely to blow up the caller when called with interrupts disabled -- it uses spin_unlock_irq() there! This *must* be fixed.
--- Atsushi Nemoto
WBR, Sergei
