On Mon, Mar 19, 2007 at 05:36:42PM +0100, Franck Bui-Huu wrote: > diff --git a/include/asm-mips/mach-generic/dma-coherence.h b/include/asm-mips/mach-generic/dma-coherence.h > index 76e04e7..3a2ac54 100644 > --- a/include/asm-mips/mach-generic/dma-coherence.h > +++ b/include/asm-mips/mach-generic/dma-coherence.h > @@ -28,6 +28,13 @@ static inline unsigned long plat_dma_addr_to_phys(dma_addr_t dma_addr) > return dma_addr; > } > > +static inline unsigned long plat_dma_addr_to_virt(dma_addr_t dma_addr) > +{ > + unsigned long addr = plat_dma_addr_to_phys(dma_addr); > + > + return (unsigned long)phys_to_virt(addr); > +} > + Putting this function into include/asm-mips/mach-generic/dma-coherence.h breaks the build for all machines that don't include this header. I applied your patch with this issue fixed. Ralf