Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Mar 2007 01:02:20 +0900 (JST)
Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:

> The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on
> receiving.  Recent fix of MIPS dma_sync_single_for_cpu() reveal this
> bug.
> 
> Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
> ---
> This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2.
> 
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index ec888db..eed78b5 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -58,12 +58,13 @@
>   *	1.34	Fix netpoll locking.  "BH rule" for NAPI is not enough with
>   *		netpoll, hard_start_xmit might be called from irq context.
>   *		PM support.
> + *	1.35	Fix an usage of streaming DMA API.
>   */

Please don't use comments as changelog anymore. It gets out of date.
The use of change control systems has made this practice obsolete.

-- 
Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux