Andrew Morton wrote: > > On Fri, 23 Feb 2007 17:28:19 -0600 Marc St-Jean > <stjeanma@xxxxxxxxxxxxxx> wrote: > > [PATCH] drivers: PMC MSP71xx GPIO char driver > > > > Patch to add a GPIO char driver for the PMC-Sierra > > MSP71xx devices. > > > > This patch references some platform support files previously > > submitted to the linux-mips@xxxxxxxxxxxxxx list. > > Thanks for the feedback Andrew. I've implemented all your recommendations other than the kernel thread handling, which I still have to look into. [...] > > > +/* -- Module functions -- */ > > + > > +static int msp_gpio_blinkthread( void *none ) > > Why is this a "module function"? The reason is likely because it's only called by msp_gpio_init so it was considered part of the module code. I'll move the comment to only cover msp_gpio_init/exit. [...] > > +module_init(msp_gpio_init); > > +module_exit(msp_gpio_exit); > > + > > +EXPORT_SYMBOL(msp_gpio_in); > > +EXPORT_SYMBOL(msp_gpio_out); > > +EXPORT_SYMBOL(msp_gpio_mode); > > +EXPORT_SYMBOL(msp_gpio_blink); > > +EXPORT_SYMBOL(msp_gpio_noblink); > > What uses these exports? These exports are needed for other drivers compiled as modules can control the GPIO pins through this driver. [...] Marc
