Re: [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dale Farnsworth wrote:
We were using the platform_device.id field to identify which ethernet
port is used for mv643xx_eth device.  This is not generally correct.
It will be incorrect, for example, if a hardware platform uses a single
port but not the first port.  Here, we add an explicit port_number field
to struct mv643xx_eth_platform_data.

This makes the mv643xx_eth_platform_data structure required, but that
isn't an issue since all users currently provide it already.

Signed-off-by: Dale Farnsworth <dale@xxxxxxxxxxxxxx>

---

 arch/mips/momentum/jaguar_atx/platform.c  |    8 ++
 arch/mips/momentum/ocelot_3/platform.c    |    8 ++
 arch/mips/momentum/ocelot_c/platform.c    |    4 +
arch/powerpc/platforms/chrp/pegasos_eth.c | 2 arch/ppc/syslib/mv64x60.c | 12 +++-
 drivers/net/mv643xx_eth.c                 |   59 ++++++++++----------
include/linux/mv643xx.h | 1 7 files changed, 62 insertions(+), 32 deletions(-)

ACK but not applied, patch corrupted




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux