On Mon, 26 Feb 2007 18:12:55 -0600 Marc St-Jean <stjeanma@xxxxxxxxxxxxxx> wrote: > [PATCH 2/5] mips: PMC MSP71xx mips common > > Patch to add mips common support for the PMC-Sierra > MSP71xx devices. > > These 5 patches along with the previously posted serial patch > will boot the PMC-Sierra MSP7120 Residential Gateway board. > > Thanks, > Marc > > Signed-off-by: Marc St-Jean <Marc_St-Jean@xxxxxxxxxxxxxx> > --- > Re-posting patch with two recommended changes: > 1. Dropped the PMC_MSP_UNCACHED configuration item as this was > already available in arch/mips/Kconfig.debug. > 3. Dropped 'else' case to simplify patch to do_watch() in > arch/mips/kernel/traps.c > > arch/mips/Kconfig | 78 ++++++++++++++++++++ > arch/mips/Makefile | 8 ++ > arch/mips/kernel/head.S | 8 ++ > arch/mips/kernel/traps.c | 6 + > include/asm-mips/bootinfo.h | 12 +++ > include/asm-mips/mipsregs.h | 30 +++++++ > include/asm-mips/regops.h | 168 > ++++++++++++++++++++++++++++++++++++++++++++ > include/asm-mips/war.h | 11 ++ 8 files changed, 321 insertions(+) My mailer kind of made a mess of things, hope I caught them all. > diff --git a/arch/mips/kernel/head.S b/arch/mips/kernel/head.S > index 6f57ca4..d7451b1 100644 > --- a/arch/mips/kernel/head.S > +++ b/arch/mips/kernel/head.S > @@ -130,10 +130,18 @@ > .endm > > /* > + * Reserverd space not required for PMC boards, although we need to > + * jump to kernel start. > + */ > +#ifdef CONFIG_PMC_MSP > + jal kernel_entry > +#else > + /* > * Reserved space for exception handlers. > * Necessary for machines which link their kernels at KSEG0. > */ > .fill 0x400 > +#endif /* CONFIG_PMC_MSP */ This is getting kind of ugly. There are a whole lot of config choices that need to use the 'j kernel_entry'. Do they all have to have their own? I'm not sure what the best way is to handle them all. > diff --git a/include/asm-mips/bootinfo.h b/include/asm-mips/bootinfo.h > index c7c945b..ab29fd4 100644 > --- a/include/asm-mips/bootinfo.h > +++ b/include/asm-mips/bootinfo.h > @@ -213,6 +213,18 @@ > #define MACH_GROUP_NEC_EMMA2RH 25 /* NEC EMMA2RH (was 23) */ > #define MACH_NEC_MARKEINS 0 /* NEC EMMA2RH Mark-eins */ > +/* > + * Valid machtype for group PMC-MSP > + */ > +#define MACH_GROUP_MSP 23 /* PMC-Sierra MSP boards/CPUs */ > +#define MACH_MSP4200_EVAL 0 /* PMC-Sierra MSP4200 Evaluation board */ > +#define MACH_MSP4200_GW 1 /* PMC-Sierra MSP4200 Gateway demo board */ > +#define MACH_MSP4200_FPGA 2 /* PMC-Sierra MSP4200 Emulation board */ > +#define MACH_MSP7120_EVAL 3 /* PMC-Sierra MSP7120 Evaluation board * / > +#define MACH_MSP7120_GW 4 /* PMC-Sierra MSP7120 Residential Gateway board */ > +#define MACH_MSP7120_FPGA 5 /* PMC-Sierra MSP7120 Emulation board */ > +#define MACH_MSP_OTHER 255 /* PMC-Sierra unknown board type */ > +#define CL_SIZE COMMAND_LINE_SIZE Really I would add MACH_GROUP_MSP after MACH_GROUP_NEC_EMMA2RH, perhaps 27 or 28, rather than an interior number. Especially if you are going to put it after MACH_GROUP_NEC_EMMA2RH in the file. ~:^) Cheers, a
