On Sat, Feb 17, 2007 at 01:12:20AM +0900, Atsushi Nemoto wrote:
> Date: Sat, 17 Feb 2007 01:12:20 +0900 (JST)
> To: vagabon.xyz@xxxxxxxxx
> Cc: ralf@xxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx
> Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
> From: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
> Content-Type: Text/Plain; charset=us-ascii
>
> On Fri, 16 Feb 2007 16:32:53 +0100, Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote:
> > These functions are aliases to __copy_{to,from}_user resp but they
> > are not allowed to sleep. Therefore might_sleep() must not be used
> > by their implementions.
>
> This changes CONFIG_PREEMPT_VOLUNTARY behavior.
> In this case might_sleep() is not just an annotation.
>
> Well, so currently CONFIG_PREEMPT_VOLUNTARY seems broken. Maybe we
> need separete functions anyway.
The issue needed to be tackled so while suboptimal I've added a chainsawed
version of memcpy to provide __copy_from_user_inatomic. Not elegant but
hopefully that will be cleaned soon. memcpy could use a general ovehaul
anyway.
Ralf
