On Thu, 1 Feb 2007 13:20:15 +0000 (GMT), "Maciej W. Rozycki" <macro@xxxxxxxxxxxxxx> wrote: > > if CONFIG_64BITS and ${load-y} in CKSEG0 > > cflags-y += -msym32 > > endif > > > > what do you think ? > > I do not see enough of justification for -msym32 to be forced. This will > also raise the minimum version of binutils required to 2.16 for the > affected platforms, which may be a little bit too aggressive. Well, $(call cc-option,-msym32) can be used safely. AFAIK -msym32 was added to gcc 4.0 which was released on Apr 2005, and binutils 2.16 was release on May 2005. So if gcc accepted -msym32 we can assume binutils accept too. I think killing BUILD_ELF64 and adding -msym32 automatically are good idea. Also I do not think __pa_page_offset() is critical for performance. --- Atsushi Nemoto