Eric, really good job! Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) Acked-By: Kirill Korotaev <dev@xxxxxxxxxx> 14/59 - minor (extra space) 25/59 - minor note 33/59 - not sorted sysctl IDs 45/59 - typo 50/59 - copyright/file note 51/59 - copyright/file name/kconfig option notes 56,58,59/59 - will review tomorrow another issue I have to think over is removal of de->owner. Alexey Dobriyan has sent recently patching fixing /proc <-> modules refcounting. I guess w/o these patches your changes are not safe if proc_handler or strategy are functions from the module. Thanks, Kirill > There has not been much maintenance on sysctl in years, and as a result is > there is a lot to do to allow future interesting work to happen, and being > ambitious I'm trying to do it all at once :) > > The patches in this series fall into several general categories. > > - Removal of useless attempts to override the standard sysctls > > - Registers of sysctl numbers in sysctl.h so someone else does not use > the magic number and conflict. > > - C99 conversions so it becomes possible to change the layout of > struct ctl_table without breaking everything. > > - Removal of useless claims of module ownership, in the proc dir entries > > - Removal of sys_sysctl support where people had used conflicting sysctl > numbers. Trying to break glibc or other applications by changing the > ABI is not cool. 9 instances of this in the kernel seems a little > extreme. > > - General enhancements when I got the junk I could see out. > > Odds are I missed something, most of the cleanups are simply a result of > me working on the sysctl core and glancing at the users and going: What? > > Eric > _______________________________________________ > Containers mailing list > Containers@xxxxxxxxxxxxxx > https://lists.osdl.org/mailman/listinfo/containers > >
