Re: [PATCH] Add support for Cobalt Server front LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Peter,

The patch I resend last night is using COBALT_LED_PORT. Is there anything else 
that needs to be changed ? Thank you in advance for your answer

Le mardi 16 janvier 2007 10:53, Peter Horton a écrit :
> Florian Fainelli wrote:
> > This patch adds support for controlling the front LED on Cobalt Server.
> > It has been tested on Qube 2 with either no default trigger, or the
> > IDE-activity trigger. Both work fine. Please comment and test !
>
> Why did you add COBALT_LED_BASE when there was already a COBALT_LED_PORT
> define on the line above ?
>
> All your
>
> 	*(volatile uint8_t *) COBALT_LED_BASE = n;
>
> can be replaced by
>
> 	COBALT_LED_PORT = n;
>
> P.

-- 
Cordialement, Florian Fainelli
---------------------------------------------
5, rue Charles Fourier
Chambre 1202
91011 Evry
http://www.alphacore.net
(+33) 01 60 76 64 21
(+33) 06 09 02 64 95
---------------------------------------------
Association MiNET
http://www.minet.net
---------------------------------------------
Institut National des Télécommunication
http://www.int-evry.fr/telecomint
---------------------------------------------

Attachment: pgpr9Qc18SMP6.pgp
Description: PGP signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux