Re: [PATCH] Add support for Cobalt Server front LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yoichi,

I first used the COBALT_LED_PORT address but it did not work for a reason I 
ignore. If I use the COBALT_LED_BASE as defined, which is taken from the CoLo 
code, it works fine.

Do know you what could explain this difference ? Can you test it on your 
boxes ?

Thank you very much in advance for your answer.

Le lundi 15 janvier 2007 23:42, Yoichi Yuasa a écrit :
> Hi,
>
> On Mon, 15 Jan 2007 19:36:52 +0100
>
> Florian Fainelli <florian.fainelli@xxxxxxxxxxx> wrote:
> > Hi all,
> >
> > This patch adds support for controlling the front LED on Cobalt Server.
> > It has been tested on Qube 2 with either no default trigger, or the
> > IDE-activity trigger. Both work fine. Please comment and test !
> >
> > Thanks
> >
> > Florian
> >
> > Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxx>
> >
> > diff -urN linux-2.6.19.1/include/asm-mips/mach-cobalt/cobalt.h
> > linux-2.6.19.1.led/include/asm-mips/mach-cobalt/cobalt.h
> > --- linux-2.6.19.1/include/asm-mips/mach-cobalt/cobalt.h       
> > 2006-12-11 20:32:53.000000000 +0100
> > +++ linux-2.6.19.1.led/include/asm-mips/mach-cobalt/cobalt.h   
> > 2007-01-15 19:29:07.000000000 +0100
> > @@ -97,6 +97,7 @@
> >                 (PCI_FUNC (devfn) << 8) | (where)), GT_PCI0_CFGADDR_OFS)
> >
> >  #define COBALT_LED_PORT                (*(volatile unsigned char *)
> > CKSEG1ADDR(0x1c000000))
> > +#define COBALT_LED_BASE         0xbc000000
>
> You don't need COBALT_LED_BASE.
> Because COBALT_LED_PORT is already defined.
>
> Yoichi

-- 
Cordialement, Florian Fainelli
---------------------------------------------
5, rue Charles Fourier
Chambre 1202
91011 Evry
http://www.alphacore.net
(+33) 01 60 76 64 21
(+33) 06 09 02 64 95
---------------------------------------------
Association MiNET
http://www.minet.net
---------------------------------------------
Institut National des Télécommunication
http://www.int-evry.fr/telecomint
---------------------------------------------

Attachment: pgpn7lWVeiq0i.pgp
Description: PGP signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux