On Thu, 11 Jan 2007 14:31:16 +0000
Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote:
> On Thu, Jan 11, 2007 at 02:55:58PM +0900, Yoichi Yuasa wrote:
>
> > This patch has fixed IDE resources problem about Cobalt.
> >
> > pcibios_fixup_device_resources() changes non-movable resources.
> > It cannot be changed if there is IORESOURCE_PCI_FIXED in the resource flags.
>
> <Ralf> anemo: Have you seen Yoichi's patch?
> <anemo> Ralf: yes, but I could not see why ... My impression is IORESOURCE_PCI_FIXED and io_offset adjustment is irrerevant.
> <Ralf> This whole fixup thing is really meant to handle machines where there is an offset between PCI bus addresses and CPU physical addresses.
> <Ralf> And that exists regardless of IORESOURCE_PCI_FIXED
> <anemo> I thought so too. So I can not see why youichi's patch fix something.
> <Ralf> This may be the explanation:
> <Ralf> static struct pci_controller cobalt_pci_controller = {
> <Ralf> .pci_ops = >64111_pci_ops,
> <Ralf> .mem_resource = &cobalt_mem_resource,
> <Ralf> .mem_offset = 0,
> <Ralf> .io_resource = &cobalt_io_resource,
> <Ralf> .io_offset = 0 - GT_DEF_PCI0_IO_BASE,
> <Ralf> };
> <Ralf> I think he should have io_offset = 0.
When I tried io_offset = 0, tulip net driver didn't work.
> Which is what other GT-64120 platforms are using, so I wonder why that is
> different on Cobalt.
I don't know, but io_offset is needed for Cobalt.
Yoichi
