On Tue, 21 Nov 2006 18:31:30 +0300, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:
> > diff --git a/arch/mips/kernel/irq-msc01.c b/arch/mips/kernel/irq-msc01.c
> > index e1880b2..bcaad66 100644
> > --- a/arch/mips/kernel/irq-msc01.c
> > +++ b/arch/mips/kernel/irq-msc01.c
> > @@ -117,6 +117,7 @@ struct irq_chip msc_levelirq_type = {
> > .mask = mask_msc_irq,
> > .mask_ack = level_mask_and_ack_msc_irq,
> > .unmask = unmask_msc_irq,
> > + .eoi = unmask_msc_irq,
> > .end = end_msc_irq,
> > };
>
> You don't have to define eoi() method for the level flow. And you don't
> need end() method anymore.
Yes, .eoi is not used level flow handler, but I thought this irq chip
is possibly used with handle_percpu_irq flow handler. And I kept .end
method for old __do_IRQ users.
---
Atsushi Nemoto
