On Sun, 22 Oct 2006 12:39:58 -0700 (PDT), Manish Lachwani <m_lachwani@xxxxxxxxx> wrote: > The init_mips_clocksource() call is made via > module_init(). It does not need to be explicitly > called in time_init() after plat_timer_setup(). Yes, module_init() can do this, but I have no good reason to use module_init() here. Actually x86's hpet.c, i8253.c and tsc.c are using module_init(), these usages would avoid modifying i386/kernel/time.c every time new clocksource added. For MIPS, init_mips_clocksource is generic and live in mips/kernel/time.c, so I feel calling it directly is good and enough. --- Atsushi Nemoto
