On Thu, 19 Oct 2006 16:01:45 +0900 (JST) Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Thu, 19 Oct 2006 15:41:38 +0900, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote: > > > +#define _LLCONST_(x) x ## L > > ^^ ^ > > The name is not corresponding to reality. > > It's not so good. > > Indeed. How about this? > > > Subject: Use "long" for 64-bit values on 64-bit kernel. > > Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx> > > diff --git a/include/asm-mips/addrspace.h b/include/asm-mips/addrspace.h > index 45c706e..7401711 100644 > --- a/include/asm-mips/addrspace.h > +++ b/include/asm-mips/addrspace.h > @@ -19,12 +19,17 @@ #ifdef __ASSEMBLY__ > #define _ATYPE_ > #define _ATYPE32_ > #define _ATYPE64_ > -#define _LLCONST_(x) x > +#define _CONST64_(x) x > #else > #define _ATYPE_ __PTRDIFF_TYPE__ > #define _ATYPE32_ int > +#ifdef CONFIG_64BIT > +#define _ATYPE64_ long > +#define _CONST64_(x) x ## L > +#else > #define _ATYPE64_ long long > -#define _LLCONST_(x) x ## LL > +#define _CONST64_(x) x ## LL > +#endif > #endif <snip> It's good for me. Thanks, Yoichi
