On Tue, 26 Sep 2006 23:43:40 +0900 (JST), Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > In handle_sys and its variants, we must reload some registers which > might be clobbered by trace_hardirqs_on(). > Also we must make sure trace_hardirqs_on() called in kernel level (not > exception level). And there is one more suspicious code in arch/mips/kernel/entry.S: FEXPORT(restore_partial) # restore partial frame #ifdef CONFIG_TRACE_IRQFLAGS SAVE_STATIC SAVE_AT SAVE_TEMP LONG_L v0, PT_STATUS(sp) and v0, 1 beqz v0, 1f jal trace_hardirqs_on b 2f 1: jal trace_hardirqs_off 2: RESTORE_TEMP RESTORE_AT RESTORE_STATIC #endif RESTORE_SOME RESTORE_SP_AND_RET .set at Is this correct if CONFIG_MIPS_MT_SMTC enabled? --- Atsushi Nemoto
