Re: [MIPS] Fix COW D-cache aliasing on fork

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 31 Aug 2006 21:32:39 +0100, linux-mips@xxxxxxxxxxxxxx wrote:
> Author: Atsushi Nemoto <anemo@xxxxxxxxxxxxx> Thu Aug 24 00:31:30 2006 +0900
> Comitter: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Thu Aug 31 19:50:02 2006 +0100
> Commit: b895b66990f22a8a030c41390c538660a02bb97f
> Gitweb: http://www.linux-mips.org/g/linux/b895b669
> Branch: master

Thanks!!!

And please commit this fix too.


The tlbidx variable should be signed int so that "tlbidx < 0"
comparison works correctly.  Nigel Stephens <nigel@xxxxxxxx> pointed
this out.

Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>

diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c
index 2cfdc0b..bbc9458 100644
--- a/arch/mips/mm/init.c
+++ b/arch/mips/mm/init.c
@@ -136,7 +136,7 @@ static inline void *kmap_coherent(struct
 	unsigned long vaddr, flags, entrylo;
 	unsigned long old_ctx;
 	pte_t pte;
-	unsigned int tlbidx;
+	int tlbidx;
 
 	inc_preempt_count();
 	idx = (addr >> PAGE_SHIFT) & (FIX_N_COLOURS - 1);


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux