On Thu, Aug 24, 2006 at 10:15:31AM +0900, Atsushi Nemoto wrote: > On Wed, 23 Aug 2006 17:52:25 +0100, Nigel Stephens <nigel@xxxxxxxx> wrote: > > Doesn't tlbidx need to be declared as a signed int, else the compiler > > could optimize away this comparison. > > You are right. I'll fix it. Thanks. Your patch also still contains copy_user_page(). The only user of it used to be copy_user_highpage() so after our rewrite it can go away. I've already applied both fixes to my working version of the patch. Your patch only maps the source page. I'm trying to map the destination page also and I'm hitting a few issues with it. Ralf