On Tuesday 22 August 2006 02:59, Yoichi Yuasa wrote: > > If you have an another standard 8250 port. this driver cannot support it > You should do as well as AU1X00. > > Yoichi The AU1X00 code obviously assumes that every port that is not an AU1X00 is a standard port requiring no register mapping. However, this is of course not necessarily true in the most general case. There could be platforms with multiple ports, all non-standard, but in different ways. Handling this would require per-port mapping functions, which could be achieved by adding function pointers to struct uart_8250_port. However, this would add the overhead of a real, non-inlined function call to every register access. Also, it seems to me that the whole register-mapping stuff conflicts with autodetection, because autoconfig() uses serial_inp() and serial_outp() before the port types, and hence the mapping requirements, are known. This is not a problem for me, however, since the correct port type is set up by the platform using early_serial_setup(). -- Thomas Koeller, Software Development Basler Vision Technologies An der Strusbek 60-62 22926 Ahrensburg Germany Tel +49 (4102) 463-390 Fax +49 (4102) 463-46390 mailto:thomas.koeller@xxxxxxxxxxxxx http://www.baslerweb.com
