Re: [PATCH] Remove mfinfo[64] used by get_wchan()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Aug 2006 09:50:57 +0200, Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote:
> >> +	unsigned long size = 0;
> > 
> > You must pass some non-zero size even if CONFIG_KALLSYMS was not set.
> > Otherwise schedule_mfi will not be initialized as expected.  Actually,
> > this is not a problem of this patch, but we missed this point on
> > previous cleanups for the get_frame_info()...
> 
> or maybe we can just fix get_frame_info() and make it more robust ?

Maybe.  But info->func_size == 0 is valid input when it was called via
show_backtrace.  If an exception occured on a first instruction of a
function, get_frame_info() should return 1.  So it would be easy to
give some appropriate (128?) size here.

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux