On Mon, Aug 14, 2006 at 09:21:24AM -0700, Randy.Dunlap wrote: > On Mon, 14 Aug 2006 17:30:33 +0200 Sam Ravnborg wrote: > > > On Mon, Aug 14, 2006 at 10:14:45AM -0400, Joseph Fannin wrote: > > > On Sat, Aug 12, 2006 at 01:49:23AM +0200, Thomas Koeller wrote: > > > > On Friday 11 August 2006 22:56, Dave Jones wrote: > > > > > On Thu, Aug 10, 2006 at 11:19:13PM +0200, > > > > > thomas@xxxxxxxxxxxxxxxxxx wrote: > > > > > > + > > > > > > +#include <linux/config.h> > > > > > > > > > > not needed. > > > > > > > > It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT. > > Yes you do - try it. > > make V=1 tells you that -include include/linux/autoconf.h pulls in > > the CONFIG_ definitions. > > Sure, autoconf.h is included, but I think his point is that > CONFIG_WATCHDOG_NOWAYOUT may not be defined there at all, > as in my 2.6.18-rc4 autoconf.h file, since my .config file says: > # CONFIG_WATCHDOG_NOWAYOUT is not set As Wim pointed out, linux/watchdog.h has this magick.. #ifdef CONFIG_WATCHDOG_NOWAYOUT #define WATCHDOG_NOWAYOUT 1 #else #define WATCHDOG_NOWAYOUT 0 #endif Which takes some of the ugly out of the drivers :-) Dave -- http://www.codemonkey.org.uk