Hi Rodolfo, On Thu, Aug 10, 2006 at 03:36:58PM +0200, Rodolfo Giometti wrote: > Again as above. For my specific board I use: > > #if defined(CONFIG_MIPS_DB1200) > data = bcsr->sig_status & val; > #elif defined(CONFIG_MIPS_MYBOARD) > specific code... > #endif > > Maybe we should modify my solution including other DB1x00 boards > ifdef. However, the important thing is to protect againt variable > "bcsr" if a specific board doesn't support it. FWIW, I think the whole Db/Pb board specific mess should be removed from the driver entirely and placed in the respective boards' code. The board should then pass on a struct to the driver with hooks into those functions (like in arch/arm/mach-pxa/corgi.c). It is on my list of things to fix for a later time. If noone beats me to it, I'm going to do it, but it may take a while since I'm working on other things. Thanks, -- ml.
