On Mon, 7 Aug 2006 17:35:25 +0200 "Franck Bui-Huu" <vagabon.xyz@xxxxxxxxx> wrote: > 2006/8/7, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx>: > > Hi > > > > On Fri, 04 Aug 2006 15:32:52 +0200 > > Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote: > > > > > This function although doing simple things is hard to follow. It's > > > mainly due to: > > > > > > - a lot of #ifdef > > > - bad local names > > > - redundant tests > > > > > > So this patch try to address these issues. It also do not use > > > max_pfn global which is marked as an unused exported symbol. > > > > > > As a bonus side, it's now really easy to see what part of the > > > code is for no-numa system. > > > > > > There's also no point to make this function inline. > > > > I seem to be able to bring together two #idef CONFIG_BLK_DEV_INITRD/#endif. > > > > Before doing that can you wait until tomorrow ? Yes I can. > I'm going to send a > patchset that going futher in the cleanup than this single patch but I > can't send it until tomorrow... OK Thanks, Yoichi
