Atsushi Nemoto wrote: > On Tue, 1 Aug 2006 11:27:16 +0200, Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote: >> When CONFIG_KALLSYMS is not set stack local is not initialized. Therefore >> show_trace() won't display anything useful. This patch uses >> prepare_frametrace() to setup the stack pointer before calling >> show_trace(). > > It's not a bug. The original show_trace() needs an address on stack > and dump_stack() surely give it by taking an address of local > variable. > sorry, was drunk when writing the commit message... > Eliminating the #ifdef itself looks good, but if you cleared contents > of the "regs" before prepare_frametrace, you will get less false > entries in the output. > well I don't see why...show_trace() is going to only use regs[29] which is setup by prepare_frametrace()... One other thing, why did you mark prepare_frametrace() as noinline ? I would mark it as always_inline to get one less false entry in the output. Franck
