On Wed, 05 Jul 2006 10:35:28 +0200, Franck Bui-Huu <vagabon.xyz@xxxxxxxxx> wrote: > > #elif defined(CONFIG_NEED_MULTIPLE_NODES) > > why not using: > > #elif defined(CONFIG_DISCONTIGMEM) || defined(CONFIG_NUMA) > > hence, we would have all memory model cases. While NEED_MULTIPLE_NODES is defined if DISCONTIGMEM || NUMA, it seems no difference. > For now it seems to be implemented only in sgi-ip27 machine. Maybe we should > make things clear by adding: > > #ifdef CONFIG_SGI_IP27 > #define pfn_valid [...] > #else > #error discontigmem model is only supported by sgi-ip27 platforms. > #error Please try to implement a generic solution if you plan to > #error use this memory model. Good luck ;) > #endif /* CONFIG_SGI_IP27 */ Though the pfn_valid() is only used by ip27 for now, I suppose it could be used other NUMA systems (not sure). --- Atsushi Nemoto
