On Mon, Jun 05, 2006 at 05:43:10PM +0200, Rodolfo Giometti wrote: > here my proposal to add APM (emu) support into mips tree. It's just > the one for ARM adapted... > > I have tested it on my au1100 based board with a battery pack. Also > the command: > > $ apm --suspend > > works correctly! Looking good, indeed. There is a sore spot though. Your patch creates arch/mips/kernel/apm.c as an essentially unmodified copy of arch/arch/kernel/apm.c and the latter as you have found is actually portable code. So I suggest you rather move that file to drivers/char/ and use it for both architectures. Ralf
