Ralf Baechle wrote: > On Thu, May 04, 2006 at 02:04:49PM -0700, Tom Rini wrote: > >> Let me ask a stupid question. With all of the ways to otherwise do a >> cross compile, why a config option on MIPS? ARM*/SH*, which are at >> least as likely to not be native-compiled, don't do that. Just >> something I've always wondered, really. > > Having such information in an environment variable is imho terribly > inelegant, having to pass it on the command line for each make > invocation > is terrible abuse for the fingertips so I went for this option which > makes > the makefile pick the right prefix. And a great solution it would be, if it actually picked the right prefix. :-) I understand that having the cross-compiler prefix specified outside the build system has drawbacks. When I first got into embedded Linux (many years ago), I was struck by the inelegance of this also. However, hardcoding the prefixes in the Makefile is, IMHO, not such a great idea either. It really doesn't bother me if the "standard" prefixes are encoded in a Makefile, but it would be nice to be able to select a non-standard prefix the same way as for other Linux architectures. I understand I can do that by turning off the "I'm cross-compiling" option, but that seems counterintuitive given the current wording of that option (not-withstanding the not-yet-mainlined help text). My patch allows to keep the current behaviour, but also supports use of the environment variable. I don't see any downside to it, unless you are actively trying to discourage the use of the environment variable. In my own experience, use of the environment variable, while inelegant for manual use, has certain benefits for automated use. Regards, -- Tim ============================= Tim Bird Architecture Group Chair, CE Linux Forum Senior Staff Engineer, Sony Electronics =============================
