Re: [PATCH] 8250_early console support for au1x00

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Rodolfo Giometti wrote:
On Thu, May 04, 2006 at 06:35:55PM +0400, Sergei Shtylyov wrote:

  The following 2 fragments are kind of contradictory:

I see, but I decided to keep it different since the kernel message is:

   Adding console on ttyS0 at MMIO 0x11100000 (options '115200')

and setting it as:

   Adding console on ttyS0 at AU 0x11100000 (options '115200')

sounds bad to me. :)

Yes. But the error msg emmitted by your patch would look this way, i.e. AU, not MMIO. No symmetry. :-)

And, as I said. there's not much sense in calling iomap() on Alchemy UART, UPIO_IOREMAP flag wasn't really needed...


Mmm... to be «coherent» I think it should be done...

Wouldn't hurt, just useless. So, I think no special checks are needed to avoid it. :-)

Ciao,

Rodolfo

WBR, Sergei


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux