On Sat, Apr 29, 2006 at 09:01:59PM -0700, Randy.Dunlap wrote: > In arch/mips/syscall.c::_sys_sysmips(), case SETNAME, > isn't one of the strncpy() and strlcpy() unneeded? > > down_write(&uts_sem); > strncpy(system_utsname.nodename, nodename, len); > nodename[__NEW_UTS_LEN] = '\0'; > strlcpy(system_utsname.nodename, nodename, > sizeof(system_utsname.nodename)); > up_write(&uts_sem); Seems that came with the 2.5.70 merge and got copied and moved around a few times since. I'm pretty sure the whole sysmips(SETNAME, ...) operation is unused. Any objections again removal of sysmips(SETNAME, ...) support? Ralf
