Hello. Sergei Shtylyov wrote:
On Mon, 17 Apr 2006 17:06:23 +0400, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:
I agree with you. Then how about something like CONFIG_NE2000_RTL8019_BYTEMODE?
Have you looked at the patch? RTL8019 is easily detectable at runtime, so the limitation is easily enforcable w/o extra Kconfig option, I think
Well, I meant something like:
#elif defined(CONFIG_NE2000_RTL8019_BYTEMODE) # define DCR_VAL 0x48 #else # define DCR_VAL 0x49
to avoid changing #elif line every time when we want to support a new board with byte-mode RTL8019AS. Of course, calculating DCR_VAL at runtime would be much better but I'm not sure if we can do it ...
Hm, with only 3-4 known boards so far (all Toshiba RBTX49[23][78], RBTX4925 also has the chip but I see no 2.6 support for this board), I doubt that it's worth the effort. And the option sounds a bit "too specific", IMO. :-)
Especially given the fact that it can't be attributed to RTL8019 only. Historically, there was CONFIG_NE2000_8BIT option but it's been eliminated long ago. Maybe it's worth reviving it indeed...
--- Atsushi Nemoto
WBR, Sergei
