On Mon, Feb 27, 2006 at 10:52:36AM +0000, Martin Michlmayr wrote: > @@ -360,10 +367,10 @@ static void ip22zilog_status_handle(stru > * But it does not tell us which bit has changed, we have to keep > * track of this ourselves. > */ > - if ((status & DCD) ^ up->prev_status) > + if ((status ^ up->prev_status) ^ DCD) Shouldn't this be (status ^ up->prev_status) & DCD ? > uart_handle_dcd_change(&up->port, > (status & DCD)); > - if ((status & CTS) ^ up->prev_status) > + if ((status ^ up->prev_status) ^ CTS) Shouldn't this be (status ^ up->prev_status) & CTS ? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core
