On Fri, 2006-03-17 at 09:38 -0700, Jordan Crouse wrote: > On 17/03/06 02:02 +0100, elmar gerdes wrote: > > > > hi folks, > > Greetings Elmar. > > > @@ -2070,6 +2070,7 @@ > > printk(KERN_ERR "%s: au1000_tx_timeout: dev=%p\n", dev->name, dev); > > reset_mac(dev); > > au1000_init(dev); > > + set_rx_mode(dev); // EG 2006-03-15: set promiscuous mode > > dev->trans_start = jiffies; > > netif_wake_queue(dev); > > I would move the comment to the previous line, use standard /* */ notation, > and your name and the date isn't really needed, as that information will > be stored in the GIT log. > > Also, don't forget your Signed-off-by line and a short description of the > patch for posterity. > > Other then that, I have no problems with the bug - unless Pete wants to > object, I think you should send the fixed-up patch to netdev@xxxxxxxxxxxxxxx > and CC this list. Nah, you're owner/reviewer now ;) Pete
