Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > > >>>>> On Tue, 7 Mar 2006 18:09:07 +0000, Ralf Baechle <ralf@xxxxxxxxxxxxxx> said: > ralf> Below's fix results in exactly the same code size on all > ralf> compilers and configurations I've tested it. > > ralf> I also have another more elegant fix which as a side effect > ralf> makes get_unaligned work for arbitrary data types but it that > ralf> one results in a slight code bloat: > > I tested the patch attached on several MIPS kernel (big/little, > 32bit/64bit) with gcc 3.4.5. In most (but not all) case, Ralf's fix > resulted better than the previous fix. > hmm, well, your earlier patch has had more testing on various platforms, for what that's worth. I think for 2.6.16 we should run with that. If you want to prepare a patch which implements Ralf's version for post-2.6.16 then that would be good, thanks.