On Tue, Mar 07, 2006 at 12:17:21PM -0000, Hamilton, Ian wrote:
> Hi Greg,
>
> I spotted this in the current latest version of ohci-au1xxx.c (accessed
> via git web interface):
>
> 94
> 95 if (dev->resource[1].flags != IORESOURCE_IRQ) {
> 96 pr_debug ("resource[1] is not IORESOURCE_IRQ");
> 97 retval -ENOMEM;
> 98 }
> 99
>
> instead this from Martin's patch:
>
> diff --git a/drivers/usb/host/ohci-au1xxx.c
> b/drivers/usb/host/ohci-au1xxx.c
> index aa4d0cd..d8fb1bb 100644
> --- a/drivers/usb/host/ohci-au1xxx.c
> +++ b/drivers/usb/host/ohci-au1xxx.c
> @@ -94,7 +94,7 @@ int usb_hcd_au1xxx_probe (const struct h
>
> if (dev->resource[1].flags != IORESOURCE_IRQ) {
> pr_debug ("resource[1] is not IORESOURCE_IRQ");
> - retval = -ENOMEM;
> + return -ENOMEM;
> }
>
> Line 97 produces a warning, but doesn't stop the build, so may have been
> missed.
Can you check the -mm tree to see if it is fixed there or not? That has
the patches that are pending from my usb tree in it.
And if not, can you send me a patch against the latest -mm?
thanks,
greg k-h
