* Jordan Crouse <jordan.crouse@xxxxxxx> [2006-03-01 11:30]:
> Martin Michlmayr spotted this potentially serious bug. Please apply.
Please don't send patches as MIME attachments. Here it is again (with
a better summary too):
[PATCH] Alchemy OCHI: return if right resources cannot be obtained
From: Jordan Crouse <jordan.crouse@xxxxxxx>
Failure to get the right resources should immediately return. Current
code has the possiblity of running off into the weeds. Spotted by
Martin Michlmayr.
Signed-off-by: Jordan Crouse <jordan.crouse@xxxxxxx>
Signed-off-by: Martin Michlmayr <tbm@xxxxxxxxxx>
---
drivers/usb/host/ohci-au1xxx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ohci-au1xxx.c b/drivers/usb/host/ohci-au1xxx.c
index aa4d0cd..d8fb1bb 100644
--- a/drivers/usb/host/ohci-au1xxx.c
+++ b/drivers/usb/host/ohci-au1xxx.c
@@ -94,7 +94,7 @@ int usb_hcd_au1xxx_probe (const struct h
if (dev->resource[1].flags != IORESOURCE_IRQ) {
pr_debug ("resource[1] is not IORESOURCE_IRQ");
- retval = -ENOMEM;
+ return -ENOMEM;
}
hcd = usb_create_hcd(driver, &dev->dev, "Au1xxx");
--
Martin Michlmayr
http://www.cyrius.com/
