Re: jiffies_64 vs. jiffies

[Nick Piggin <nickpiggin@xxxxxxxxxxxx>]

Atsushi Nemoto wrote:
> > > > > > On Wed, 01 Mar 2006 23:52:37 +1100, Nick Piggin <nickpiggin@xxxxxxxxxxxx> said:
>
>
> > > void do_timer(struct pt_regs *regs)
> > > {
> > > -	jiffies_64++;
> > > -	update_times();
> > > +	update_times(++jiffies_64);
> > > 	softlockup_tick(regs);
> > > }
>
>
> nick> jiffies_64 is not volatile so you should not have to obfuscate
> nick> the code like this.
>
> Well, do you mean it should be like this ?
>
> 	jiffies_64++;
> 	update_times(jiffies_64);

Yeah. It makes your patch a line smaller too!

> Thanks for your comments.

Oh it was nothing really ;)

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com