Re: rfc about an uncommented string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 Oct 2005, Fuxin Zhang wrote:
> Geert Uytterhoeven wrote:
> > On Mon, 10 Oct 2005, Fuxin Zhang wrote:
> >>We are using 8172 for 2.4 kernels presently,although may drop it
> >>sometime later.
> >>
> >>I don't read the 2.6 code,but it seems it remains the same as the copy
> >>in 2.4(except that #ifdef changes).I can't see why the code is broken?
> >>In case you mean the ioport address,mips_io_port_base for that board is
> >>0xa0000000, inb(0x14000060) is reading from 0xb4000060, which is correct
> >>for it.
> > 
> > Shouldn't mips_io_port_base be 0xb4000000 for your board, so inb(0x60) looks
> > more like a PC-style keyboard controller access?
> It is not my code. But anyway the board has more than one discontinuous
> io ranges(0xb4000000 is in fact for it8712 superio and legacy ios,

So 0xb4000000 is the base for ISA and PCI I/O port accesses, right? Hence if
mips_io_port_base is 0xb4000000, all drivers for PCI (and ISA) expansion cards
that use inb() and friends will work.

> it8172's system registers are located around 0xb8000000, while others
> begins at 0xb4010000).

So these can use ITE8172-specific access macros.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux