Re: [patch] db1550: useless memset() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 22, 2005 at 03:32:02PM +0400, kbaidarov wrote:

> I've try kernel without memset() on the board - is ok, board boot.
> All drivers works fine. Than I grep the kernel sources:
> 
> [root@windmill linux]# grep -nri "memset(irq_desc" arch/
> arch/mips/au1000/common/irq.c:449:      memset(irq_desc, 0, 
> sizeof(irq_desc));
> arch/mips/ite-boards/generic/irq.c:184:        memset(irq_desc, 0, 
> sizeof(irq_desc));
> [root@windmill linux]#
> 
> Only 2 matches! Does we needs memset() at all?
> And if some one try to initialize irq_desc from start_kernel() before 
> arch_init_irq() call, then following arch_init_irq() call discard all that 
> initialization.

Exactly, so the initialization is wrong, so I'm removing both calls.

Thanks,

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux