On Fri, Sep 30, 2005 at 12:32:41PM +0900, Atsushi Nemoto wrote: > Date: Fri, 30 Sep 2005 12:32:41 +0900 (JST) > To: linux-mips@xxxxxxxxxxxxxx > Cc: ralf@xxxxxxxxxxxxxx > Subject: Re: missing data cache flush for signal trampoline on fork > From: Atsushi Nemoto <anemo@xxxxxxxxxxxxx> > Content-Type: Text/Plain; charset=us-ascii > > >>>>> On Wed, 28 Sep 2005 20:57:58 +0900 (JST), Atsushi Nemoto <anemo@xxxxxxxxxxxxx> said: > anemo> Sorry, this would corrupt cpu_has_ic_fills_f_dc case. Revised. > > The patch was overkill. The indexed-flush is required only for > d-cache. Revised. Hmm... Your patch may be right for the time being but I think this should the whole flushing biz should actually be handled via update_mmu_cache by adding something along the lines of: ... if (vma->flags & VM_EXEC) do_flush_icache_page(addr); ... What do you think? Ralf
