Alan,
Thanks for your suggestion.
I'm not sure how to write a .fixup handler. I did some Googling, but got
nowhere. I looked through drivers/ide to see what drive->unmask was doing.
I found this in ide-io.c:
if (drive->unmask)
local_irq_enable();
And this in ide-taskfile.c:
if (!drive->unmask)
local_irq_disable();
I modified both of these files so that execution would be as if unmask = 1.
This resulted in no change of behavior.
Bryan
-----Original Message-----
From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx]
Sent: Friday, August 26, 2005 11:47 AM
To: Bryan Althouse
Cc: linux-mips@xxxxxxxxxxxxxx; 'Ralf Baechle'
Subject: RE: custom ide driver causes "Badness in smp_call_function"
On Gwe, 2005-08-26 at 10:58 -0400, Bryan Althouse wrote:
> Ralf,
>
> The patch doesn't seem to make any difference. :(
Assuming your hardware is sane another approach might be to force
drive->unmask = 1. That will mean that PIO mode is running with
interrupts enabled which should avoid the problem.
Add a .fixup handler to your driver (assuming you are using a recent
2.6.x) and in the handler do something like this:
+void ide_unmask_interrupts(ide_hwif_t *hwif)
+{
+ int i;
+ for (i = 0; i < 2; i++) {
+ ide_drive_t *drive = &hwif->drives[i];
+ if(drive->present)
+ drive->unmask = 1;
+ }
+}
hopefully that will be early enough.
