On Fri, Jul 22, 2005 at 02:10:30PM +0200, Thiemo Seufer wrote: > Date: Fri, 22 Jul 2005 14:10:30 +0200 > To: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxx > Subject: Re: CVS Update@xxxxxxxxxxxxxx: linux > Content-Type: text/plain; charset=us-ascii > From: Thiemo Seufer <ths@xxxxxxxxxxxx> > > Ralf Baechle wrote: > > On Thu, Jul 21, 2005 at 04:33:53PM +0100, ths@xxxxxxxxxxxxxx wrote: > > > > > Modified files: > > > arch/mips/kernel: binfmt_elfo32.c > > > include/asm-mips: elf.h > > > > > > Log message: > > > Fix ELF defines: EF_* is a field, E_* a distinct flag therein. > > > > Remarkably bad idea after the old definitions are already being used since > > over a decade. > > Well, kernel headers are less widely used than others, and everywhere > else it is E_*. Since > - kernel headers in general aren't meant as an interface for userland, > - the definition is inconsistent to the userland one, Glibc is the only thing elf.h that defines the E_* names at all and explicitly says "don't use". > - the in-kernel use seems to be limited to the ELF binary object > loader and probably third party modules loaders > I found moving to a consistent definition to be more useful than > keeping the old inconsistent one. I think you're confusing binutils's internal definitions with the use everywhere else. Mind pulling that patch? Ralf
