On Thu, Jun 23, 2005 at 12:08:39PM +0100, Maciej W. Rozycki wrote: > On Wed, 22 Jun 2005, Andrew Isaacson wrote: > > If the CPU Options get out of sync with the CONFIG_CPU_ options, > > cpu_cache_init() can end up being a noop. Stop with a useful message > > in that case rather than running on without cache functions. > > Wouldn't a build-time error be a better option? The code looks like it's structured to be able to be compiled with support for multiple CPUs, say, r4k and SB1; using #error would seem to prevent that. With the code as currently structured, you don't know it's going to be a noop until runtime comes along and cpu_has_4ktlb is true... -andy
