Franck Bui-Huu wrote: > Hi Thiemo > > Thiemo Seufer wrote: > > >That place in setup.c _had_ virt_to_phys before. It fails to build > >for 64bit code in 32bit objects with reasonably modern toolchains > >(which means all 64bit kernels currently supported in CVS). > > > yes, but can't we modify "virt_to_phys" or "__pa" directly instead of > adding some new uses of CPHYSADDR in setup.c We shouldn't. virt_to_phys accepts typesafe addresses, while CPHYSADDR only juggles the bits of an unsigned long around. Degrading virt_to_phys to the standard of CPHYSADDR isn't an improvement. Thiemo
