Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maciej,

Maciej W. Rozycki wrote:
On Wed, 1 Dec 2004, Manish Lachwani wrote:


The attached patch implements preempt_disable/preempt_enable around the
SB1 DMA page operations. Please review ...


 Why is it needed?

 Also I think these:

-   if [ "$CONFIG_SIBYTE_SB1250" = "y" ]; then
+   if [ "$CONFIG_SIBYTE_BOARD" = "y" ]; then

are unrelated and inaccurate. The devices are internal to the SoCs and not strictly board-dependent. How about:

+ if [ "$CONFIG_SIBYTE_SB1250" = "y" || "$CONFIG_SIBYTE_BCM112X" = "y"]; then

Actually, this makes more sense. I will send a new patch

Thanks
Manish Lachwani


at the very least, or perhaps using reverse dependencies?

Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux