Maciej W. Rozycki wrote:
On Fri, 20 Aug 2004 ralf@xxxxxxxxxxxxxx wrote:
Log message: Undo change from rev 1.37; some userspace software is expecting PAGE_SIZE, PAGE_SHIFT and PAGE_MASK to be accessible through <asm/page.h>. Sigh ...
Fix that software then, instead of breaking good one (hint -- what is the
"right" value of PAGE_SHIFT and why it doesn't work for that system over
there?). With these macros exported it's hard to guess whether the page
size can be hardcoded or it should get determined at the run time. And with glibc you get a compilation error due to PAGE_SHIFT being undefined. Please revert the braindamage.
What software is the offender, BTW?
Maciej
procps is probably the trigger of this. Me and some other Gentoo/MIPS devs/users got into a bit of a heated discussion w/ the procps maintainer, who didn't quite like the fact that A) We don't use "sanitized" kernel headers B) PAGE_SIZE was hidden on MIPS and C) "properly sanitized" headers would provide PAGE_SIZE. We opted instead for a patch to procps that used sysconf(_SC_PAGESIZE) to fetch the value, and I guess this just didn't rub the right way w/ the maintainer. Got me.
I can post the discussions for those interested (or just looking for amusement), and anyone curious enough can look at proc/procps.h in the procps tree for a rather amusing (IMHO) comment on MIPS at the top of the source.
--Kumba
--
"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the eyes of the great are elsewhere." --Elrond
