On Tue, Jul 20, 2004 at 05:03:56PM -0700, Song Wang wrote: > Should #ifdef _KERNEL__ be added before #include > <spaces.h> in asm-mips/addrspace.h? > > I think the reason is the same as when you added > the #ifdef __KERNEL__ before #include <spaces.h> > for asm-mips/page.h. Some userspace software is expecting to get PAGE_SHIFT, PAGE_SIZE and PAGE_MASK to be available in userspace via <asm/page.h>, so I protected the inclusion of <asm/spaces.h> with __KERNEL__ but left the definitions of these symbols unprotected. Ralf
