On Thu, May 27, 2004 at 04:31:53PM +0200, Emmanuel Michon wrote: > On 64bit you substract 1ULL<<32 > > Substracting 1 is enough for it to be algorithmically correct even on > 64bit > Do you accept a patch with the version for CONFIG_LLSC = y using a > substraction by 1? This sounds wrong - the current algorithm is manipulating two 32-bit variables held in a single register. If you change the algorithm like this you will manipulate the wrong variable. Anyway, I don't see why the code fails for you. With CONFIG_CPU_HAS_LLSC set and CONFIG_CPU_HAS_LLDSCD disabled it should just work for you. The suggestion in my prevous mail was meant for a rewrite along the lines of for example ppc64 - an algorithm that's mostly C and almost portable even. Ralf
