On Tue, Mar 09, 2004 at 06:33:08PM -0800, Jun Sun wrote:
> With swarm running on 2.6 I just saw the net dev names are
> not set correctly. See below.
>
> eth%d: SiByte Ethernet at 0x10064000, address: 00-02-4C-FE-0C-B2
> eth%d: enabling TCP rcv checksum
>
> It appears alloc_netdev() assigns this initial name and nobody
> later resets it to a more meaningful name.
>
> Any body has a clue here? I don't think it is driver's job though ...
It's always the driver :-)
It's referencing net_device->name before register_netdev.
There's plenty of other small candy in that driver, for example in
sbmac_cleanup_module():
dev = dev_sbmac[idx];
if (!dev) {
struct sbmac_softc *sc = dev->priv;
unregister_netdev(dev);
sbmac_uninitctx(sc);
free_netdev(dev);
}
Better make sure the pointer is NULL before we dereference it. We don't
want to miss a crash, do we ;-)
Ralf
